[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12136 - trunk/subversion/libsvn_client

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2004-12-03 05:38:55 CET

philip@tigris.org writes:

> Author: philip
> Date: Thu Dec 2 21:20:00 2004
> New Revision: 12136
>
> Modified:
> trunk/subversion/libsvn_client/ra.c
> Log:
> Add a bit of sanity checking, and get rid of a bit of silly disk IO.
>
> * subversion/libsvn_client/ra.c (set_wc_prop): Make sure there is a
> versioned entry before setting the property.

See my mail to the dev-list about why this bug exists. I hadn't
thought of this solution. But now that you mention (by way of making)
it, this seems a pretty safe thing to do. It will likely mean that
switched working copies made with 1.2 clients against 1.0 or 1.1
servers will have no dav wcprops, but that's only a one time
performance hit.

(Heh. In fact, this makes me wonder why we bother doing the resource
walk during 'svn switch' at all -- we really could speed up switch by
*not* doing it, though at the cost of subsequent operations fetching
wcprops on an as-needed basis.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 3 05:42:37 2004

This is an archived mail posted to the Subversion Dev mailing list.