Re: svn commit: r12074 - branches/svnserve-ssl/subversion/libsvn_ra_svn

On Mon, Nov 29, 2004 at 02:08:35PM -0500, Greg Hudson wrote:
> I'm not terribly happy with the idea of adding timeout and I/O-pending
> operations on all streams, when they're only going to be used in very
> specific contexts. Specific functionality should not be driven deeply
> into commonly-used layers of a system.
>

I agree, but I didn't feel that this case was clear-cut. The run-time
cost of the additional function pointers is virtually nil, and the
implementation does not complicate the existing code.

> Could we instead create an abstraction, specific to the libsvn_ra_svn
> implementation, which contains an svn_stream_t * and also functions for
> timeouts and whether I/O is pending?
>

Sure; I don't feel strongly one way or the other.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 29 20:51:50 2004