[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFC: Change "revert" behaviour

From: Max Bowsher <maxb_at_ukf.net>
Date: 2004-11-29 18:20:15 CET

Greg Stein wrote:
> On Mon, Nov 29, 2004 at 04:43:11PM -0000, Max Bowsher wrote:
>> Greg Stein wrote:
>> ...
>>> Make paranoid the default. We always want to choose safe defaults. If
>>> somebody wants a bit more speed at the cost of "not [necessarily] as
>>> safe", then they can use a flag.
>>
>> I have to disagree. If we followed that argument, we would want to make
>> the
>> always-checksum behaviour the default for commit and diff and all the
>> others too.
>
> Revert throws out changes. commit and diff do not. Tho, arguably, if
> you make a change and it doesn't get committed, then that isn't too
> happy either. But those changes *are* still there.

Right, *but* if revert were to fail to notice a file has changed due to it's
timestamp being unchanged, that the changes *are* still there in this case
too.

The nature of the change I'm proposing is to possibly *not* destroy local
mods in a tiny edge case. Accounting for this edge case currently makes
recursive revert to slow to be effectively useful in any moderately sized
WC.

Subversion isn't, in general, designed to function well with programs which
change file contents without affecting the timestamp, so why should it
invest so much extra time in this case?

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 29 18:21:53 2004

This is an archived mail posted to the Subversion Dev mailing list.