Control characters in log message cause failure

We've had a report regarding the ASF Subversion repository where a control
character entered the log message via our cvs2svn conversion. The error
reported was:

$ svn log -r 90428 http://svn.apache.org/repos/asf
subversion/libsvn_ra_dav/util.c:670: (apr_err=175002)
svn: REPORT request failed on '/repos/asf/!svn/bc/90428'
subversion/libsvn_ra_dav/util.c:656: (apr_err=175002)
svn: The REPORT request returned invalid XML in the response: XML parse error
at line 9: not well-formed (invalid token) (/repos/asf/!svn/bc/90428)

The log was originally:

"Convert the rest of the error docs to the new type-map format.

C^XVS: If this change addresses a PR in the problem report tracking"

That ^X is Ctrl+X. Removing the ^X resolved the problem (via propedit). So,
there does exist a manual way to resolve this.

However, I have left revision 102002 up so others can (hopefully) debug this:

% svn log -r102002 http://svn.apache.org/repos/asf
svn: REPORT request failed on '/repos/asf/!svn/bc/102002'
svn: The REPORT request returned invalid XML in the response: XML parse error
at line 9: internal error. (/repos/asf/!svn/bc/102002)

It's log message is:

<quote>
Improve Spanish custom error messages.

Submitted by: Sim^[,As^[(B <sim6 cataloniamail.com>
Reviewed by: Daniel Lopez <daniel rawbyte.com>
</quote>

^[ is the control character here.

Let me know if I should file an issue if someone can't easily fix this. =)
Issue #1025 is the closest I can find, but is about *entering* control
characters in a log message via SVN - not about one that entered through other
means. =)

Thanks! -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 29 06:26:32 2004