Re: svn commit: r12012 - in trunk/subversion: libsvn_client libsvn_wc tests/clients/cmdline

kfogel@collab.net writes:

>> - SVN_ERR (svn_wc_cleanup (subdir, adm_access, diff3_cmd,
>> + /* ### I'd like to pass subpool and close the batons as we go
>> + ### but we probably need 2.0 for such a behaviour change */
>> + SVN_ERR (svn_wc_cleanup (entry_path, adm_access, diff3_cmd,
>> cancel_func, cancel_baton, pool));
>
> What happens if we pass subpool right now? If we're recursing
> depth-first, and we close batons from the bottom up, how is that a
> visible behavior change?
>
> (Not arguing, just not understanding something.)

At present if an baton is passed to svn_wc_cleanup all the access
batons opened are returned (yes, the function suffers from incomplete
documentation in svn_wc.h). If svn_wc_cleanup didn't have to return
the batons then we could close them as we go and make better use of
the subpool. svn_wc_cleanup2 isn't really an answer, since we would
still have to provide svn_wc_cleanup.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org