Re: Extra warnings

Philip Martin wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>> Philip Martin wrote:
>>> I also use -Wshadow -Wdeclaration-after-statement
>>
>> Interesting. "-Wpointer-arith -Wwrite-strings -Wshadow" were already
>> added to my build - by the auto-tools?
>
> By Subversion's configure.in when you specify --enable-maintainer-mode.

We already have a (currently unused, IIRC) macro to conditionally add CFLAGS
depending on whether the compiler accepts them.

How about using this to add -Wdeclaration-after-statement and any other
warnings people think appropriate, when a suitable gcc version is being
used?

Certainly -Wdeclaration-after-statement would have caught a few problems
that have happened in the past.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 24 12:40:50 2004