Greg Hudson wrote:
> The reason *not* to consider your keywords-as-hash change now is that we
> have to rev svn_subst_build_keywords() once for keywords-as-hash and a
> second time for properties-as-keywords. (This would be okay if
[...]
> In fact, the keywords-as-hash change you submitted added properties as
> an argument to svn_subst_build_keywords() in anticipation of the
> properties-as-keywords change. I don't agree with doing that before
> we're ready to have properties as keywords.
John, I think I agree with everything Greg said (not just the bits I quote
above), which rather dampens my enthusiasm for your properties-as-hash.
We might still consider having it as a "modest design improvement" in Greg's
words, given that you have done the work towards it, if others are happy with
it, which probably means you will have to leave out that extra properties
argument that Greg mentions even if you feel it will be necessary later. I
don't know ... see what others say.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 15 19:43:37 2004