Re: svn commit: r11838 - trunk/subversion/libsvn_subr

Branko Čibej <brane@xbc.nu> writes:
> >+ svn_error_clear (err);
> >+ /* Do the best we can. */
> >+ abs_path = (*path == '\0') ? "." : path;
> >
> This conversion is unnecessary...
>
> >+ }
> >+ return apr_psprintf (pool, "%s", svn_path_local_style (abs_path, pool));
> >
> ...because you call svn_path_local_style, which, incidentally, already
> converts "" to ".".

Thanks! I'll tweak.

> BTW, when did we decide to always return absolute paths in error messages?

Frankly, I'm not sure, although I can think of arguments for and
against. I think I lean slightly toward "for". But mainly I was
assuming (perhaps wrongly) that issue #1538 indicated some sort of
pre-existing consensus about this.

Are you just asking out of curiosity, or would you like to do
something different?

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 12 17:20:59 2004