[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11838 - trunk/subversion/libsvn_subr

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-11-12 06:48:16 CET

kfogel@tigris.org wrote:

>+static const char *
>+path_for_err_msg (const char *path, apr_pool_t *pool)
>+{
>+ const char *abs_path;
>+ svn_error_t *err = svn_path_get_absolute (&abs_path, path, pool);
>+ if (err)
>+ {
>+ /* We can't return an error, because this is for use within errors. */
>+ svn_error_clear (err);
>+ /* Do the best we can. */
>+ abs_path = (*path == '\0') ? "." : path;
>
>
This conversion is unnecessary...

>+ }
>+ return apr_psprintf (pool, "%s", svn_path_local_style (abs_path, pool));
>
>
...because you call svn_path_local_style, which, incidentally, already
converts "" to ".".

BTW, when did we decide to always return absolute paths in error messages?

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 12 06:48:03 2004

This is an archived mail posted to the Subversion Dev mailing list.