Re: abort or verify?

On Wed, Nov 10, 2004 at 03:29:59AM +0000, Julian Foad wrote:
> Julian Foad wrote:
> >In most of the places where we currently say:
> >
> > if (blah) abort();
> >
> >I feel we should be saying:
> >
> > assert(!blah);
>

I believe that we should always have code of the form:

    assert(!blah);
    if (blah)
      {
        /* do some reasonable thing */
      }

In some cases, that would manifest itself as:

    assert(x);
    if (!x)
      return svn_error_create(...);

In some cases, that would manifest itself as:

    assert(x);
    if (!x)
      abort();

Because the assertion generates such rich error messages,
it should be favored over abort(), but the abort() should
not be discarded when there is no reasonable way to proceed.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 10 16:48:02 2004