Issue #2064 and libsvn_wc/diff.c

Hi,

This wants a libsvn_wc guru:-)

Working my way through issue #2064 and the redesign of the wc_diff_callbaks, I'm currently working on diff.c in libsvn_wc. There, we have code to do either WC -> WC comparisons or WC -> repos dito. In many places in file_diff and directory_elements_diff, there is code to check for modifications between WC and pristine copy before calling the diff callbacks supplied by the user. Then, but only if use_text_base is TRUE, the callbacks are actually called. I would say that file_diffs has no vissible side effects if use_text_base is true. Also, dir_elements_diff will crawl through the directory structure, checking for files or directories that weren't already diffed (i.e. that weren't different in the repository revision) even if use_text_base is false. I don't see why this is happening, since if use_text_base is false, local modifications are uninteresting anyway.

I would like to clean this up if it is correct, but I ask here first, since I don't know if this code have some subtle, but essential, side effects in the !use_text_base case that I don't see.

Any ideas?

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 4 19:20:16 2004