> Certainly I think the ability to save and restore a file's mtime is useful.
> I'm not sure if a normal file property is the right place to store the time
> - it seems very odd to have a property that the user can modify but
> Subversion will always overwrite any value that the user puts in it.
I believe that is just a matter of documentation - after all, it's immensely
useful to do a
svn ps svn:text-time "2004-01-01T02:03:04.000000Z" <URL>
and have the file the correct time someone updates ....
> One question (I haven't tested this patch to try to find the answer): when
> you modify the property during a commit, do you also modify the text-base
> version of that property and the working version of it?
Well, it better should be done locally too - that's why there is a
SVN_ERR (svn_wc_prop_set (SVN_PROP_TEXT_TIME,
propval, path, adm_access, pool) );
in the patch.
> Please write a log message, in the style described in the HACKING file.
>
> I'm sorry I don't have time to review the code functionally at the moment,
> but I am interested so I will try to do so soon.
Thank you very much!
Of course if there's someone of the core developers interested I'll likely put
more effort into this, eg. write a log message :-)
As long as I'm the only user it seemed not worth the time - especially because
a log message has to include the function names, and I don't know an
automated way to generate that (haven't read HACKING yet, though)
> For now, I will just say: please pay attention to the formatting of the
> source code. Try to set up your editor to help you with this. If you use
> vi(m) or emacs, use the configuration files available in
> tools/dev/svn-dev.{el,vim} in the Subversion source tree. Don't use tab
> characters for indentation; don't put a space after an open parenthesis or
> before a close parenthesis; put spaces around operators, including "=";
> when a parenthesised expression is continued onto the next line, continue
> it from the column just after the open parenthesis.
I tried to follow the indentation - but if there's a config file for vi I'll
use that next time.
The indentation is the least of my worries :-)
Thank you for your time!
Regards,
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 4 14:52:55 2004