[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11640 - in trunk: . subversion/libsvn_subr subversion/tests/libsvn_subr

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-10-28 02:07:35 CEST

philip@tigris.org writes:

> Author: philip
> Date: Wed Oct 27 17:31:58 2004
> New Revision: 11640
>
> Added:
> trunk/subversion/tests/libsvn_subr/compat-test.c
> Modified:
> trunk/build.conf
> trunk/subversion/libsvn_subr/version.c
> Log:
> Fix svn_ver_compatible to correctly test release minor numbers.
> Patch by Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de>,
> regression test tweaked by philip.

I think the change in this patch is correct, I'm not altogether sure
about the rest of the function. The behavior is demonstrated
explicitly by the regression test (a step forward even if the patch is
wrong):

> + struct version_pair {
> + svn_version_t my_version;
> + svn_version_t lib_version;
> + svn_boolean_t result;
> + } versions[] = {
> + { {1, 0, 0, ""}, {1, 0, 0, ""}, TRUE },
> + { {1, 0, 0, ""}, {2, 0, 0, ""}, FALSE },
> + { {2, 0, 0, ""}, {1, 0, 0, ""}, FALSE },
> +
> + { {1, 0, 0, ""}, {1, 0, 1, ""}, TRUE },
> + { {1, 0, 1, ""}, {1, 0, 0, ""}, TRUE },
> + { {1, 0, 1, ""}, {1, 0, 1, ""}, TRUE },
> +
> + { {1, 0, 0, ""}, {1, 1, 0, ""}, TRUE },
> + { {1, 0, 1, ""}, {1, 1, 0, ""}, TRUE },
> + { {1, 0, 0, ""}, {1, 1, 1, ""}, TRUE },
> + { {1, 1, 0, ""}, {1, 0, 0, ""}, FALSE },

The above result for released versions...

> +
> + { {1, 0, 0, "dev"}, {1, 0, 0, "dev"}, TRUE },
> + { {1, 0, 1, "dev"}, {1, 0, 1, "dev"}, TRUE },
> + { {1, 1, 0, "dev"}, {1, 1, 0, "dev"}, TRUE },
> + { {1, 1, 1, "dev"}, {1, 1, 1, "dev"}, TRUE },
> + { {1, 0, 0, "dev"}, {1, 0, 1, "dev"}, FALSE },
> + { {1, 0, 0, "dev"}, {1, 1, 0, "dev"}, FALSE },
> + { {1, 0, 0, "cev"}, {1, 0, 0, "dev"}, FALSE },
> + { {1, 0, 0, "eev"}, {1, 0, 0, "dev"}, FALSE },
> + { {1, 0, 1, "dev"}, {1, 0, 0, "dev"}, FALSE },
> + { {1, 1, 0, "dev"}, {1, 0, 0, "dev"}, FALSE },
> +
> + { {1, 0, 0, ""}, {1, 0, 0, "dev"}, FALSE },
> +
> + { {1, 0, 0, "dev"}, {1, 0, 0, ""}, FALSE },
> + { {1, 0, 1, "dev"}, {1, 0, 0, ""}, TRUE },
> + { {1, 1, 0, "dev"}, {1, 0, 0, ""}, TRUE },

...differs from the result for this development version.

> + { {1, 1, 1, "dev"}, {1, 0, 0, ""}, TRUE },
> + { {2, 0, 0, "dev"}, {1, 0, 0, ""}, FALSE },
> + { {1, 0, 0, "dev"}, {2, 0, 0, ""}, FALSE },
> + };

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 28 02:07:54 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.