[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11211 - trunk/subversion/mod_dav_svn

From: Tobias Ringström <tobias_at_ringstrom.mine.nu>
Date: 2004-10-04 19:30:37 CEST

Thanks for reviewing the patch, Karl!

kfogel@collab.net wrote:

>Quick sanity check: the reason this is okay is because of the
>paragraph in section 5 of notes/authz_policy.txt, that says:
>
> * If a revision has a mixture of readable/unreadable
> changed-paths, then all revprops are unreadable, except for
> svn:author and svn:date. All revprops are unwritable.
>
>right? The only properties we're grabbing here are svn:author and
>svn:date, exactly the two that are allowed even if there are some
>other unreadable paths in the revision. Therefore all we need to know
>is that *at least* one path is readable, and we do know that.
>
>Am I on the right track?
>
>
Absolutely.

>...your new comment also says "date" when in fact we're fetching the
>author.
>
>The comment should maybe also state the at-least-one-readable-path
>policy for author, to remind the programmer of why this is okay.
>
>
Right, I'll add that.

>This is exactly the same code as before, right? Maybe worth
>abstracting?
>
>
I though it was too few lines, but I'll take a look at it again.

>Here "date" is correct :-).
>
>But this comment also could maybe state the at-least-one-readable-path
>policy for dates, as a reminder. Most people won't know the authz
>policy by heart.
>
>
Roger that!

Food now, patch to fix comments soon... :-)

/Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 4 19:31:24 2004

This is an archived mail posted to the Subversion Dev mailing list.