[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11155 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_ra_dav libsvn_ra_local libsvn_ra_svn libsvn_repos mod_dav_svn svnserve tests/clients/cmdline/getopt_tests_data

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2004-09-28 04:01:04 CEST

Philip Martin wrote:

>> /* Parse the arguments. */
>>- SVN_ERR(svn_ra_svn_parse_tuple(params, pool, "l(?r)(?r)bb", &paths,
>>+ SVN_ERR(svn_ra_svn_parse_tuple(params, pool, "l(?r)(?r)bb?n", &paths,
>> &start_rev, &end_rev, &changed_paths,
>>- &strict_node));
>>+ &strict_node, &limit));
>>+ if (limit == SVN_RA_SVN_UNSPECIFIED_NUMBER)
>
>
> ../svn/subversion/svnserve/serve.c: In function `log_cmd':
> ../svn/subversion/svnserve/serve.c:897: warning: comparison between signed and unsigned
>
> Should limit be apr_uint64_t rather than int?
>

Interesting. I don't see that warning here (of course not, Murphy's Law
dictates that such things should only show up on someone else's
machine). I suppose it should, since that's what svn_ra_svn_parse_tuple
will be expecting. I will need to pass it into svn_repos_get_log3
eventually though, will a simple cast to int be correct in that case?

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 28 04:00:56 2004

This is an archived mail posted to the Subversion Dev mailing list.