[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10772 - trunk/subversion/libsvn_client

From: Mark Benedetto King <mbk_at_lowlatency.com>
Date: 2004-08-30 16:55:44 CEST

On Mon, Aug 30, 2004 at 05:44:47AM -0500, jpieper@tigris.org wrote:
>
> - if ((entry->kind == svn_node_file)
> - && (! propval)
> - && (is_special))
> + if (((! propval) && (is_special)) ||
> + ((propval) && (! is_special)))
> {

An alternative form:

     if ((! propval) != (! is_special))
       {

Ignoring readability, there is a performance reason for this change:
most C optimizers aren't smart enough to prove that the original's
short-circuiting branches are unneccesary.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 30 16:56:12 2004

This is an archived mail posted to the Subversion Dev mailing list.