Tobias Ringström wrote:
> Greg Hudson wrote:
>
>>So, to summarize:
>>
>> What we have now: No diagnostic, blocking lock attempt
>> mbk's alternative: Diagnostic if we can't get lock, then block
>> My alternative: Fail if we can't get lock
>> Other alternative: Diagnostic if we can't get lock, then block,
>> and print another message when we do get lock
>>
>>
> A problem with the current solution that you didn't mention is that it's
> really hard to kill svnadmin while it's waiting to acquire the lock
> because we ignore SIGINT and SIGKILL. I don't like the "fail if we can't
> get lock" approach for the reason you quoted from mbk, but it's not only
> a problem when running svnserve from inetd. You can get the same
> problems with file:// and svn+ssh://. If you have a busy server that
> serves multiple repositories, you don't want to shut down the whole
> server just to recover a single repository.
>
> The attached patch implements your "other alternative" above, and also
> makes it possible to interrupt svnadmin while waiting for the lock.
> Opinions?
+1 (concept), especially about being able to Ctrl-C whilst waiting on the
lock.
Nothing against the patch, just haven't had time to review in detail.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 30 00:41:13 2004