[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10676 - in trunk/subversion: libsvn_wc tests/clients/cmdline

From: <kfogel_at_collab.net>
Date: 2004-08-18 16:54:13 CEST

philip@tigris.org writes:
> --- trunk/subversion/libsvn_wc/questions.c (original)
> +++ trunk/subversion/libsvn_wc/questions.c Tue Aug 17 18:47:06 2004
> @@ -341,7 +341,7 @@
> apr_md5_final (digest, &context);
>
> checksum = svn_md5_digest_to_cstring (digest, pool);
> - if (strcmp (checksum, entry->checksum) != 0)
> + if (entry->checksum && strcmp (checksum, entry->checksum) != 0)
> {
> return svn_error_createf
> (SVN_ERR_WC_CORRUPT_TEXT_BASE, NULL,

A thought: If entry->checksum is NULL, then all the checksumming work
done previous to this would turn out to have been a waste. Any reason
not to add conditionals so we don't init, update, nor finalize the
context if entry->checksum is NULL?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 18 18:31:00 2004

This is an archived mail posted to the Subversion Dev mailing list.