[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #2006: severe new bug, help requested

From: <kfogel_at_collab.net>
Date: 2004-08-16 22:58:02 CEST

Philip Martin <philip@codematters.co.uk> writes:
> If we were to use something like:
>
> Index: subversion/mod_dav_svn/dav_svn.h
> ===================================================================
> --- subversion/mod_dav_svn/dav_svn.h (revision 10664)
> +++ subversion/mod_dav_svn/dav_svn.h (working copy)
> @@ -493,7 +493,8 @@
> /* Output XML data to OUTPUT using BB. Use FMT as format string for the.
> output. */
> svn_error_t * dav_svn__send_xml(apr_bucket_brigade *bb, ap_filter_t *output,
> - const char *fmt, ...);
> + const char *fmt, ...)
> + __attribute__((format(printf,3,4)));
>
> then gcc would produce a warning:
>
> /home/pm/sw/subversion/svn/subversion/mod_dav_svn/log.c: In function `log_receiver':
> /home/pm/sw/subversion/svn/subversion/mod_dav_svn/log.c:179: warning: too many arguments for format

Neat. (Is that how GCC/libc handles 'printf' specially?)

It's a lot of call sites to change in Subversion, though. Not sure
it's worth the churn or the ugliness.

What I *really* want to know is, how come log_tests.py didn't fail
when run over dav? (I'm pretty sure I've run davcheck since r10362.)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 17 00:34:41 2004

This is an archived mail posted to the Subversion Dev mailing list.