[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.1rc1 performance regression in 'svn status' (and also 1.1rc2)

From: Mark Benedetto King <mbk_at_lowlatency.com>
Date: 2004-08-14 15:25:59 CEST

On Fri, Aug 13, 2004 at 10:50:26PM +0200, Peter N. Lundblad wrote:
> On Fri, 13 Aug 2004, C.A.T.Magic wrote:
>
> >
> > Peter N. Lundblad wrote:
> > > This was discussed earlier on this thread. If a pools parent is in a
> > > different thread, this will not work. You can't use a xlate handle in
> > > different threads at the same time, AFAICK.
> >
> > maybe you can store store the threadID together with the xlate handle,
> > and only use the pool's xlate handle if the threadIDs match?
>
> That requires locking, since another thread might be setting it during the
> test.
>
> But, what about the following approach:
> - When a pool is created in svn_pool_create(_ex), store the current
> apr_os_thread_t in the pool.
> - When we want an xlate handle, search the pool tre upwards until we are
> in a pool created by another thread or we find a handle. If the pool
> wasn't created by our routines, then we will detect that and stop.
>

We don't tell people not to trade pools between threads, so just
because a pool was created by one thread doesn't mean it won't
be in use by another.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 14 15:26:36 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.