Re: svn commit: r10521 - trunk/subversion/libsvn_subr

On Sun, 2004-08-08 at 17:49, Philip Martin wrote:
> That 15 looks prone to error, particularly if/when more types get
> added. How about something like
>
> #define LEN_STRNCMP(s) (len != sizeof(s) - 1 \
> || strncmp (mime_type, s, sizeof(s) - 1) != 0)

My experience is that overuse of the C preprocessor is infuriating when
you have to debug any of the relevant code. If we're going to introduce
extra engineering here, I'd prefer that it take the form of some tables,
rather than preprocessor macros.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 9 00:13:22 2004