[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix issue #1673 - svn merge reports File Not Found (single, unmodified,

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-08-08 23:27:52 CEST

"Marcos Chaves" <mchvs@hotmail.com> writes:

> - SVN_ERR (svn_io_remove_file (tmpfile1, pool));
> - SVN_ERR (svn_io_remove_file (tmpfile2, pool));
> + /* Ignore if temporary file not found. It may have been renamed. */
> + if ((err = svn_io_remove_file (tmpfile1, pool)) && (err->apr_err !=
> ENOENT))

Your mailer appears to have mangled the patch.

Don't check ENOENT explicitly, use APR_STATUS_IS_ENOENT instead.

> + {
> + return err;
> + }
> + if ((err = svn_io_remove_file (tmpfile2, pool)) && (err->apr_err !=
> ENOENT))
> + {
> + return err;
> + }

An svn_error_t cannot simply be abandoned, it must either be returned
or passed to svn_error_clear.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 8 23:28:06 2004

This is an archived mail posted to the Subversion Dev mailing list.