[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] gettext support for svndumpfilter's help (and error) messages

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-08-04 14:53:33 CEST

On Wed, 4 Aug 2004, Kobayashi Noritada wrote:

> When translating po file, I noticed svndumpfilter has no help messages to
> translate though it has some error messages to do so.
> So, I scanned subversion/svndumpfilter/main.c for unsupported messages,
> and tried creating a patch.

Good. There are other places in the sources that should be marked but
aren't. Feel free to go marking them if you want.

Index: subversion/svndumpfilter/main.c
===================================================================
--- subversion/svndumpfilter/main.c (revision 10468)
+++ subversion/svndumpfilter/main.c (working copy)
[...]
@@ -583,8 +583,8 @@
                     apr_hash_get (old_props, SVN_PROP_REVISION_DATE,
                                   APR_HASH_KEY_STRING));
       apr_hash_set (rb->props, SVN_PROP_REVISION_LOG, APR_HASH_KEY_STRING,
- svn_string_create ("This is an empty revision for "
- "padding.", hash_pool));
+ svn_string_create (_("This is an empty revision for "
+ "padding."), hash_pool));
You need to reindent the second line so the starting quotes are aligned.

@@ -721,20 +721,20 @@
 static const svn_opt_subcommand_desc_t cmd_table[] =
   {
     {"exclude", subcommand_exclude, {0},
- "Filter out nodes with given prefixes from dumpstream.\n"
- "usage: svndumpfilter exclude PATH_PREFIX...\n",
+ N_("Filter out nodes with given prefixes from dumpstream.\n"
+ "usage: svndumpfilter exclude PATH_PREFIX...\n"),

Same here and in all command descriptions.

       SVN_ERR (svn_cmdline_fprintf (stderr, subpool,
- "%s %sprefixes:\n",
- do_exclude ? "Excluding" : "Including",
+ _("%s %sprefixes:\n"),
+ do_exclude ? N_("Excluding") : N_("Including"),
                                     opt_state->drop_empty_revs
- ? "(and dropping empty revisions for) "
+ ? N_("(and dropping empty revisions for) ")
                                     : ""));

Please refactor this into four different messages. Message fragments are
hard to translate correctly.

Else, it seems OK to me.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 4 14:46:33 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.