[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10472 - in trunk/subversion: libsvn_repos svnadmin

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-08-04 12:39:26 CEST

sussman@tigris.org wrote:

>Author: sussman
>Date: Tue Aug 3 11:58:47 2004
>New Revision: 10472
>
>Modified:
> trunk/subversion/libsvn_repos/repos.c
> trunk/subversion/svnadmin/main.c
>Log:
>Followup to r10467: make /trunk compile on win32 again.
>
>* svnadmin/main.c (subcommand_recover): use APR_STATUS_IS_EAGAIN(),
> instead of checking directly against EWOULDBLOCK.
>
>* libsvn_repos/repos.c (get_repos): same.
>
>
>Modified: trunk/subversion/libsvn_repos/repos.c
>Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_repos/repos.c?view=diff&rev=10472&p1=trunk/subversion/libsvn_repos/repos.c&r1=10471&p2=trunk/subversion/libsvn_repos/repos.c&r2=10472
>==============================================================================
>--- trunk/subversion/libsvn_repos/repos.c (original)
>+++ trunk/subversion/libsvn_repos/repos.c Tue Aug 3 11:58:47 2004
>@@ -1046,7 +1046,7 @@
> lockfile_path = svn_repos_db_lockfile (repos, pool);
>
> err = svn_io_file_lock2 (lockfile_path, exclusive, nonblocking, pool);
>- if (err != NULL && err->apr_err == EWOULDBLOCK)
>+ if (err != NULL && APR_STATUS_IS_EAGAIN(err->apr_err))
>
>
Missing space before paren. :-)

> return err;
> SVN_ERR_W (err, "Error opening db lockfile");
> }
>
>Modified: trunk/subversion/svnadmin/main.c
>Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/svnadmin/main.c?view=diff&rev=10472&p1=trunk/subversion/svnadmin/main.c&r1=10471&p2=trunk/subversion/svnadmin/main.c&r2=10472
>==============================================================================
>--- trunk/subversion/svnadmin/main.c (original)
>+++ trunk/subversion/svnadmin/main.c Tue Aug 3 11:58:47 2004
>@@ -634,7 +634,7 @@
> err = svn_repos_recover2 (opt_state->repository_path, TRUE, pool);
> if (err)
> {
>- if (err->apr_err != EWOULDBLOCK)
>+ if (APR_STATUS_IS_EAGAIN(err->apr_err))
>
>
:-) Nitpicking is nice.

> return err;
> svn_error_clear (err);
> SVN_ERR (svn_cmdline_printf (pool,
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 4 12:39:56 2004

This is an archived mail posted to the Subversion Dev mailing list.