[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: EWOULDBLOCK on win32

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2004-08-03 16:03:11 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

> On Mon, 2004-08-02 at 20:27, mbk@tigris.org wrote:
> > Author: mbk
> > Date: Mon Aug 2 20:27:19 2004
> > New Revision: 10467
> >
> > Modified:
> > trunk/subversion/include/svn_io.h
> > trunk/subversion/include/svn_repos.h
> > trunk/subversion/libsvn_repos/repos.c
> > trunk/subversion/libsvn_subr/io.c
> > trunk/subversion/svnadmin/main.c
> > Log:
> > Make "svnadmin recover" more user-friendly by printing a warning
> > if the repository appears to be locked.
>
> > - SVN_ERR_W (svn_io_file_lock (lockfile_path, exclusive, pool),
> > - "Error opening db lockfile");
> > + err = svn_io_file_lock2 (lockfile_path, exclusive, nonblocking, pool);
> > + if (err != NULL && err->apr_err == EWOULDBLOCK)
>
> I'm setting up a nightly-build batch script on WinXP/VC6 system right
> now. The script just updated my /trunk working copy, ran gen-make.py,
> msdev, and poof... it tells me that 'EWOuLDBLOCK' is an undeclared
> identifier.

I wonder if our code shouldn't be using the APR_STATUS_IS_EAGAIN()
macro instead of testing EWOULDBLOCK directly? See apr_errno.h.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 3 18:04:35 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.