Re: svn commit: r10469 - trunk

On Tue, Aug 03, 2004 at 10:20:55AM -0400, Greg Hudson wrote:
> On Tue, 2004-08-03 at 03:46, breser@tigris.org wrote:
> > - [esyscmd(build/getversion.py subversion/include/svn_version.h)],
> > + [esyscmd(/usr/bin/env python build/getversion.py \
> > + subversion/include/svn_version.h)],
>
> Is the "/usr/bin/env" here accomplishing anything? Does esyscommand not
> do a path search?

I'm just using the exact same call that the shebang line is. I have no
objections to removing /usr/bin/env, but it was already being run.
By leaving it in I wasn't actually changing how it ends up getting run.

> (And r10470 suggests to me that we're doing something severely screwy,
> by checking out materials on Unix with CRLF line endings and then trying
> to use them. I think we've wandered off in the wrong direction.)

We're not checking them out. We're exporting them and then prepping a
distribution copy for Windows which is in CRLF. So yeah it's kinda
screwy. But the changes needed to workaround the screwiness were pretty
minor and have ended up getting us a nice Windows zip file source
package.

I've only fixed the few cases that these issues impact the creation of a
zip file. I'm sure trying to checkout in CRLF and build on unix creates
a whole slew of other issues that I haven't bothered to fix.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org