Re: svn commit: r10148 - in trunk/subversion: libsvn_repos tests/clients/cmdline

kfogel@collab.net wrote:
> Whew, thanks for fixing that pre- and post-revprop change mess, Josh!
>
> A small implementation nit: When the value is NULL, perhaps we
> shouldn't bother to create a tempfile containing only the empty
> string? Instead, we should just pass NULL, and not create a tempfile
> at all.
>
> Of course, the possibility of doing it this way was obscured by
> run_hook_cmd() not explicitly documenting that 'stdin_handle' can be
> NULL. However, many callers were already passing NULL, and one can
> trace it through to svn_io_run_cmd() to see that it's okay.

Sounds good to me, I just looked at the docstring for run_hook_cmd and
didn't actually look to see how it was implemented.

> I'd like to commit the patch below, please tell me what you think. It
> passes prop_tests 11, and some other basic tests. I haven't run the
> full test suite on it yet, but will before committing.

No objections here.

-Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 6 20:46:52 2004