[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue #1901 (double slashes screw things): Patch, and some strategy questions

From: Josh Pieper <jjp_at_pobox.com>
Date: 2004-07-03 13:28:08 CEST

Klaus Rennecke wrote:
> Ben Reser wrote:
>
> >[...]
> >
> >We need to accept double slashes. See Issue #1779 and my comments on it
> >in:
> ><20040311072104.GN13621@occipital.brain.org>
> >http://www.contactor.se/~dast/svn/archive-2004-03/0558.shtml
> >
> >The correct fix is to fix whatever is segfault when it encouters
> >multiple slashes...
> >
>
> As stated in an earlier followup
> http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=69409 I am
> pretty convinced that this issue is actually part of a more general
> problem. There should be an algorithm floting around on my desktop
> somewhere, but I don't have the time to port it from Java and check
> legal at the moment.
>
> Sorry if I'm repeating myself, but I think this may turn ugly if you fix
> the issue in small increments every time someone finds a new angle to
> this. See <http://rfc.net/rfc2396.html#s5.2.>

Yes, this is a symptom of a larger problem, namely that
svn_path_canonicalize doesn't return a canonicalized path. Canonical
would mean that any two input paths that referenced the same file
should have the same output path (at least relative to the same root).
svn_path_canonicalize should really behave more like
svn_path_get_absolute, except without the requirement that the file or
path actually exist on disk. I'm working on it now.

It seems that in addition to this problem, there may also be
sub-commands that don't canonicalize their paths/URLs before using
them. I'll see what can be done about that too afterwards.

-Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 3 13:28:59 2004

This is an archived mail posted to the Subversion Dev mailing list.