[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10091 - in trunk/subversion: include libsvn_repos svnadmin

From: <kfogel_at_collab.net>
Date: 2004-06-30 19:15:36 CEST

Tobias Ringström <tobias@ringstrom.mine.nu> writes:
> >For now, I'll fix it by adding '--verbose' to the invocation in the
> >test framework, so we don't lose any more developer time on this.
>
> You say in your next email that this didn't work which I find very
> surprising because it works perfectly here. I just changed
> load_args = ' load "' + dst_path + '"'
> to
> load_args = ' load -v "' + dst_path + '"'
>
> in main.py. All tests pass now with my patch included.

I see now what I did wrong: I added the "--verbose" as a separate
string term, but I didn't notice the double quotes that would make it
be part of dst_path in practice.

> >However, in the long term, I feel it's wrong that we changed the
> >default output format of 'svnadmin load' in a 1.x release. The output
> >formats are part of the API. If anyone is tempted to argue with that,
> >I will simply point to the current situation as proof :-).
>
> That was why I posted the patch several days before committing it.

Oh, I wasn't accusing you of dereliction of duty :-). I too failed to
think of the consequences at the time. When I wrote "we changed the
default output", it wasn't just a rhetorical device. I really meant
that it is/was all of our responsibility, not just yours.

> >I don't think we need to revert r10091. We just need to tweak it so
> >that the default is verbosity; -q produces quiet operation; we file a
> >2.0 issue to change the default; and of course we can revert the
> >band-aid change I'm about to commit to the test suite.
>
> There is already a -q option to make it quiet, but it makes it print
> nothing.
>
> I wanted a less verbose load because I've been running cvs2svn and
> svnadmin load a lot lately and the load scrolls the output so fast
> that I can't even see what revision it is at. It's not more important
> than that, so I'll drop the patch.

Well, let's at least schedule it for 2.0.

(I really like the patch. My only objection is about compatibility;
in terms of inherent desirability, the patch is a real improvement
IMHO.)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 30 20:53:46 2004

This is an archived mail posted to the Subversion Dev mailing list.