[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] r10065 makes svnadmin abort when creating fs_fs repos on Samba shares

From: Øyvind A. Holm <sunny_at_sunbase.org>
Date: 2004-06-25 09:39:11 CEST

Sitting on a Debian Linux® system and should create a fs_fs repository
on a Samba share, don't know what windows version is running on the
remote share, probably win2k. This happens:

$ svnadmin create /home/sunny/sambashare/Svn/test
svn: Can't set sgid bit on new directory '/home/sunny/sambashare/Svn/test/db': Operation not permitted
$ svn co file:///home/sunny/sambashare/Svn/test
svn: Unable to open an ra_local session to URL
svn: Unable to open repository 'file:///home/sunny/sambashare/Svn/test'
svn: Berkeley DB error while opening 'nodes' table for filesystem /home/sunny/sambashare/Svn/test/db:
No such file or directory

It aborts before it has created the db/ directory in the repository, and
the repository is incomplete. The reason for this is an error check in
subversion/libsvn_subr/io.c:dir_make() which aborts svnadmin before the
repository is propely created. The attached patch removes the error
check. I was thinking of turning the error into a warning, but as we
can't use the sgid bit anyway, why worry the user?

http://www.sunbase.org/src/subversion/patch/r10071-sgid_bit.patch
347a92c29d1c84ebf4667c1358ab414a r10071-sgid_bit.patch

[[[
Follow-on to r10065: Make it possible to use "svnadmin create" on a
Windows share if we're on a non-WIN32 system. Removes an error check
after chmod() that would abort svnadmin create before the repository is
properly created.

* subversion/libsvn_subr/io.c (dir_make): Remove error check after
  setting S_ISGID with chmod().
]]]

Regards,
Øyvind A. Holm
---------------------
cat /dev/urandom >SCO

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Jun 25 09:39:52 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.