[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Refactor locale targets into separate Makefile

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-06-21 23:22:25 CEST

Erik Huelsmann wrote:

>[ about Makefile contents ]
>
>
>
>>>+include subversion/po/Makefile
>>>
>>>
>>Does this work if src_dir != build_ir?
>>
>>
>
>I started wondering about that after I sent the mail; I'd need to try.
>Anybody?
>
>
Nope, of course it doesn't. It should be $(abs_srcdir)/po/Makefile, and
the default for abs_srcdir should be '.'. But of course, that's a minor
issue, because not all makes understand the 'include' directive with
that spelling. It's '.include' in some BSD makes I've seen. I wonder if
autoconf know how to replace that? It should...

>>>Index: subversion/po/Makefile
>>>===================================================================
>>>--- subversion/po/Makefile (revision 0)
>>>+++ subversion/po/Makefile (revision 0)
>>>@@ -0,0 +1,35 @@
>>>+
>>>+abs_srcdir ?= ../..
>>>
>>>
That's _not_ abs_srcdir... :-)

>>>+MSGFMT ?= msgfmt
>>>
>>>
>>Is ?= available in all make clones we support? Probably, since you used
>>it? :-)
>>
>>
>Hmm; no. I used it because I was looking in the (gnu) make manuals. I'll
>have a look at the nmake manuals.
>
>
It's completely GNUish, as far as I know. Hmmm...

One way to avoid this problem would be to use normal assignment, and
change to top-level makefile to _call_ this one instead of oncluding it.
That means you get to keep the suffixes, and the rules get expanded to

    $(MAKE) $@ abs_srcdir="$(abs_srcdir)" XGETTEXT="$(XGETTEXT)" MSGFMT="$(MSGFMT)"

And so on. The settings on the command line will override the
assignments in the makefile.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 21 23:23:23 2004

This is an archived mail posted to the Subversion Dev mailing list.