[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnserve could save its PID somewhere

From: Tobias Ringstr├Âm <tobias_at_ringstrom.mine.nu>
Date: 2004-06-21 11:59:25 CEST

Branko ─îibej wrote:

> Greg Hudson wrote:
>
>> On Sun, 2004-06-20 at 14:22, Tobias Ringstr├Âm wrote:
>>
>>> Oops, I see that the children are not closing the listening socket.
>>> As you say it's not strictly neccessary, but it's still a bug. I'll
>>> fix it. It should be a one-liner.
>>
>> (1) Won't APR pool cleanups take care of this?
>
> Not if you kill the process and it doesn't catch the signal and exit
> cleanly. :-)

That's not what I was talking about. Because the child processes don't
close the listening socket, it will still be open even if you kill the
parent process. That in turn means that you cannot start a new server
process until all children have terminated because the port will be
busy. Clients trying to connect to the server while the main process is
terminated by childred still exist will hang instead of abort until the
last child terminate.

>> (2) How is it a bug?
>
> It's not.

It's not an end of the world kind of bug, but it still a bug. But I
suspect that we were talking about different things.

/Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 21 12:00:29 2004

This is an archived mail posted to the Subversion Dev mailing list.