[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RA get_repos_root and URI-encoding

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-06-05 18:30:41 CEST

On Sat, 2004-06-05 at 12:26, Peter N. Lundblad wrote:
> I'm working on issue 1770 and it seems it has to do with get_repos_root in
> the ra_local library returning an URL that is not URI-encoded. (It is then
> compared to an encoded URI in svn_client__repos_locations). I don't find
> anything in the docstring in svn_ra.h telling if this URI should be
> encoded or not. It seems like ra_dav returns an encoded URL, but I haven't
> tried it.
>
> Anyone who knows what was intended? It seems most logical to work with
> encoded URIs in the API:s.

I agree. Since there is no such thing as a "decoded URI" in the real
world, any API which deals in URIs should deal in encoded URIs. So the
right answer is to treat this as a bug in ra_local and fix it.

(We can pretty much get away with having "decoded URIs" for short
periods of time in our internal processing, since we do not expect to
find special URI characters before the pathname part, with the possible
exception of the username in scheme://username@host/path. But it would
be gravely inelegant to pass around such things between libraries.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 5 18:31:22 2004

This is an archived mail posted to the Subversion Dev mailing list.