[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9855 - in trunk/subversion: libsvn_repos libsvn_wc

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-05-24 18:49:54 CEST

On Mon, 2004-05-24 at 10:49, kfogel@collab.net wrote:
> ghudson@tigris.org writes:
> > Log:
> > Fix two bugs in the handling of incomplete subdirectories. (There is
> > arguably a third bug in the update editor, in that it doesn't clear
> > the incomplete flag on a subdir if the driver doesn't open it. But
> > that bug is hard to fix, and it is currently masked because the driver
> > will open an incomplete subdir even if there are no edits to make to
> > it because it is empty.)

> Is that parenthetical aside captured anywhere in the issue tracker or
> as a comment in the code? Should it be, perhaps?

No, I don't think so.

It could conceivably become a problem if the libsvn_repos driver learns
to prune when it sees that the source and target directory are unrelated
but empty. (Why we would ever implement that optimization is unclear;
you want to prune off big chunks, not empties. Perhaps it could be a
consequence of a more comprehensive optimization.) The fix would seem
to involve a final walk of the working copy target, clearing incomplete
flags, after a successful update.

So, I guess I'll file a low-priority issue for it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 24 18:50:24 2004

This is an archived mail posted to the Subversion Dev mailing list.