Re: [PATCH] More po updates

From: Erik Hülsmann <e.huelsmann_at_gmx.net>
Date: 2004-05-23 21:33:09 CEST

('binary' encoding is not supported, stored as-is) >Index: subversion/libsvn_client/diff.c
>===================================================================
>--- subversion/libsvn_client/diff.c (revisión: 9860)
>+++ subversion/libsvn_client/diff.c (copia de trabajo)
>@@ -654,12 +654,12 @@
> {
> struct merge_cmd_baton *merge_b = baton;
> apr_pool_t *subpool = svn_pool_create (merge_b->pool);
>- const char *target_label = ".working";
>+ const char *target_label = _(".working");
> const char *left_label = apr_psprintf (subpool,
>- ".merge-left.r%ld",
>+ _(".merge-left.r%ld"),
> older_rev);
> const char *right_label = apr_psprintf (subpool,
>- ".merge-right.r%ld",
>+ _(".merge-right.r%ld"),
> yours_rev);
> svn_boolean_t has_local_mods;
> svn_boolean_t merge_required = TRUE;

I think the _() above require xgettext comments to explain their
function to translators.

>@@ -3426,7 +3429,7 @@
> {
> svn_pool_destroy (subpool);
> return svn_error_create (SVN_ERR_FS_TXN_OUT_OF_DATE, NULL,
>- "Transaction out of date.");
>+ _("Transaction out of date."));
> }
>
> /* Get the next node_id and copy_id to use. */
>@@ -3673,7 +3676,7 @@
> /* Did we find it? */
> if (kind != svn_node_dir)
> return svn_error_create (SVN_ERR_FS_NO_SUCH_TRANSACTION, NULL,
>- "No such transaction.");
>+ _("No such transaction."));
>
> txn = apr_pcalloc (pool, sizeof (*txn));

The above messages can be set to NULL as they duplicate the general
message. They are - erm - somewhere in libsvn_fs_fs... Right before:
 
>Index: subversion/libsvn_fs_fs/err.c
>===================================================================
>--- subversion/libsvn_fs_fs/err.c (revisión: 9860)
>+++ subversion/libsvn_fs_fs/err.c (copia de trabajo)
>@@ -37,7 +37,7 @@
> return SVN_NO_ERROR;
> else
> return svn_error_create (SVN_ERR_FS_NOT_OPEN, 0,
>- "filesystem object has not been opened yet");
>+ _("filesystem object has not been opened yet"));
> }
>
>

So can this one.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 23 21:33:31 2004