Peter N. Lundblad wrote:
>On Sun, 23 May 2004, C. Michael Pilato wrote:
>
>
>
>>"Peter N. Lundblad" <peter@famlundblad.se> writes:
>>
>>
>>
>>>hash table. The pool should live longer than the temporary string used by
>>>svn_cmdline_fprintf, but I still wonder if this is considered correct or
>>>if I should use a subpool.
>>>
>>>
>>Make a subpool of hash_pool, use it for your fprintf()'s (and also for
>>
>>
>
>Done.
>
>
>
>>this block, too, please):
>>
>> for (hi = apr_hash_first (hash_pool, rb->props);
>> hi;
>> hi = apr_hash_next (hi))
>>
>>
>>
>Is this that block in the same function (close_revision)? AFAIK it doesn't
>use any pools. In the loops further down in the patch, I use subpools. Or
>do I miss something?
>
>
"apr_hash_first(hash_pool, ...)"
We have to assume it uses the pool, if it requires the parameter.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 23 20:30:03 2004