On Sun, 23 May 2004, C. Michael Pilato wrote:
> "Peter N. Lundblad" <peter@famlundblad.se> writes:
>
> > hash table. The pool should live longer than the temporary string used by
> > svn_cmdline_fprintf, but I still wonder if this is considered correct or
> > if I should use a subpool.
>
> Make a subpool of hash_pool, use it for your fprintf()'s (and also for
Done.
> this block, too, please):
>
> for (hi = apr_hash_first (hash_pool, rb->props);
> hi;
> hi = apr_hash_next (hi))
>
Is this that block in the same function (close_revision)? AFAIK it doesn't
use any pools. In the loops further down in the patch, I use subpools. Or
do I miss something?
> Additinally:
>
> > Index: main.c
> > ===================================================================
> > --- main.c (revision 9862)
> > +++ main.c (arbetskopia)
> > @@ -636,15 +636,17 @@
> > SVN_ERR (svn_stream_write (rb->pb->out_stream,
> > rb->body->data , &(rb->body->len)));
> > if (! rb->pb->quiet)
> > - fprintf (stderr, _("Revision %ld committed as %ld.\n"),
> > - rb->rev_orig, rb->rev_actual);
> > + SVN_ERR (svn_cmdline_fprintf (stderr, hash_pool,
> > + _("Revision %ld committed as %ld.\n"),
> > + rb->rev_orig, rb->rev_actual));
>
> Indentation is busted here ^^^.
>
Yes, the patch wasn't completely ready yet:-) But could very well have
missed it. Thank you for pointing it out.
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 23 20:22:33 2004