[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Execute groups of log-files, was (Re: Improving the performance of libsvn_wc for checkouts/updates/switches)

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-05-23 15:13:58 CEST

Josh Pieper wrote:

>@@ -1293,29 +1296,45 @@
> a ghost open tag. */
> SVN_ERR (svn_xml_parse (parser, log_start, strlen (log_start), 0));
>
>- /* Parse the log file's contents. */
>- SVN_ERR_W (svn_wc__open_adm_file (&f, svn_wc_adm_access_path (adm_access),
>- SVN_WC__ADM_LOG, APR_READ, pool),
>- _("Couldn't open log"));
>-
>- do {
>- buf_len = sizeof (buf);
>+ for (log_number = 1; ; log_number++)
>+ {
>+ svn_pool_clear (iterpool);
>+ logfile_path = apr_psprintf (iterpool, "log.%d", log_number);
>
>
Eek. I think this should be SVN_WC__ADM_LOG ".%d", not "log.%d", to be
consistent with usage elsewhere.

>@@ -1336,9 +1355,15 @@
> }
> else
> {
>- /* No 'killme'? Remove the logfile; its commands have been executed. */
>- SVN_ERR (svn_wc__remove_adm_file (svn_wc_adm_access_path (adm_access),
>- pool, SVN_WC__ADM_LOG, NULL));
>+ for (log_number--; log_number > 0; log_number--)
>+ {
>+ svn_pool_clear (iterpool);
>+ logfile_path = apr_psprintf (iterpool, "log.%d", log_number);
>
>
Same here.

>@@ -811,7 +869,8 @@
>
> SVN_ERR (svn_wc__open_adm_file (&log_fp,
> parent_path,
>- SVN_WC__ADM_LOG,
>+ apr_psprintf (pool, SVN_WC__ADM_LOG
>+ ".%d", *log_number),
>
>
Yes, exactly like this. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 23 15:15:56 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.