Re: svn commit: r9799 - trunk/subversion/clients/cmdline

On Thu, 20 May 2004 kfogel@collab.net wrote:

> By the way, the crash bug was causing 'make check' to fail. Do you
> know about 'make check', and about running it before commit a change,

Yes, and I actually did make check, but thank you any way. I've had this
before in unoptimized builds, where a function falls off and the return
value seems OK. Think it depens on the return value from a previous
function call still being available in the CPU register for the return
value. Maybe that's why my test worked, or else I really screwed something
up...

> to make sure your change is sane? See the 'check', 'davcheck',
> 'svncheck', and 'fsfscheck' targets in Makefile.in.
>
Have to try these targets out too. Do you normally run just make check or
all of them before a commit?

> The 'make check' habit can help prevent such problems in the future :-).
>
Yes. Regression testing is very useful.. Sad that it takes some time to
run it each time. But that's one developer's time...

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 20 22:55:07 2004