[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9714 - trunk/subversion/libsvn_wc

From: Tobias Ringström <tobias_at_ringstrom.mine.nu>
Date: 2004-05-14 23:40:49 CEST

Ben Collins-Sussman wrote:
> On Fri, 2004-05-14 at 16:09, bliss@tigris.org wrote:
>
>>* subversion/libsvn_wc/adm_crawler.c
>> (report_revisions): Call svn_io_check_path for each entry instead of
>> calling svn_io_get_dirents and comparing strings.
>
> Um... isn't this going to cause a *huge* slowdown when the 'svn commit'
> scans for modified files?

I thought that svn_io_get_dirents already called stat to get the type
and that it would be the same amount of work. On a closer look (and to
my big surprise) there seems to be support for a d_type entry in the
dirent on some systems to avoid having to call stat. I'll continue
investigating and find another solution if neccessary.

/Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 14 23:41:06 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.