Re: [PATCH] Re: replacing SVN_REVNUM_T_FMT for translation

> On Tue, 11 May 2004, Peter N. Lundblad wrote:
>
> > On Mon, 10 May 2004 kfogel@collab.net wrote:
> >
> > in the patch, but anyway, here it is. I've eliminated SVN_REVNUM_T_FMT
> in
> > all .c files and replaced with ld.
> >
> When doing this, I found some instances of plain sprintf into a
> stack-allocated fixed-size buffer. Are they worth eliminating as per
> HACKING? The buffer is 20 chars long, and I think that would be too short
> if long int happens to be 64 bits on a platform.

Probably. In case you have to change function signatures to achieve this, I
don't think it is worth the trouble though. In those cases adding a #
comment saying that as soon as the signature changes the sprintf has to be
changed too.
 
> Also, I found that we are quite inconsistent in putting single quotes
> around revision numbers. I could fix this on the next pass, when I add _()
> calls. Any preference? With, or witthout single quotes? I'd say without
> since it's a plain number,

I agree. This may need a note in HACKING, although the "error messages
conventions" section may not be the right place in this case... Is it time
to rename that section to a more general name?

bye,

Erik.

-- 
NEU : GMX Internet.FreeDSL
Ab sofort DSL-Tarif ohne Grundgebühr: http://www.gmx.net/dsl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org