[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: replacing SVN_REVNUM_T_FMT for translation

From: Peter N. Lundblad <lundblad_at_softhome.net>
Date: 2004-05-10 22:08:12 CEST

On Mon, 10 May 2004, [UTF-8] Branko ─^Libej wrote:

> Peter N. Lundblad wrote:
>
> >What are the chances that long will not do for a revision number for the
> >forseable future? Isn't long at least 32 bits, at least on all platforms
> >we support? Are you expecting to change it to at least 64 bits?
> >
> >
> Yes, it is, and no, I'm not. I can't imagine a reasonable system which,
> in the foreseeable future, would have to support more than 4 billion
> distinct revisions (as opposed to transactions, of which we can have
> many more).

Not 2 billion either, I hope, since it is a signed long:-)

> >I grepped for APR_SIZE_T_FMT and APR_OFF_T_FMT. They are used in some
> >error messages (less than ten) and in other places that aren't
> >localizable, so it seems your assumption holds true.
> >
> >
> Good. So we can use Greg's suggestion for those, and forget about the rest.
>
Seems so.

> >Ofcourse, teaching gettext about our _FMT macros is out of question.
> >
> >
> Very much so. The most we could do is use C99 types and format
> constante, but of course we're not in a position to require a C99 compiler.
>
No, and I'm not sure that other gettexts will support it, so it is really
a non-starter. Just wanted to ilustrate how the gettext designer of GNU
thought about this. Not really relevant, but anyway...

> >So, since we don't really like svn_revnum_to_cstring, couldn't we just use
> >%ld as Branko suggested. If we, for some reason someday, need to change
> >the data type (to 64 bits), it isn't more than 200 text messages to
> >update. It is an evening's work, not more.
> >
> >
> Good. Let's ditch SVN_REVNUM_T_FMT then, and rplace all instances with
> %ld. GCC will warn if somebody uses the wrong format, anyway.
>
OK. I'll wait until Wednesday or something and then prepare a patch to
shit effect. Any objections?

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 10 21:59:09 2004

This is an archived mail posted to the Subversion Dev mailing list.