[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Fwd: Re: [PATCH] SVN_REVFMT_T -> svn_revnum_to_cstring]

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-05-08 21:17:37 CEST

attached mail follows:


Peter N. Lundblad wrote:

>On Sat, 8 May 2004, [UTF-8] Branko Ä^Libej wrote:
>
>
>
>>Peter N. Lundblad wrote:
>>
>>
>>
>>>Hi,
>>>
>>>Attached is a little one that turns most uses of SVN_REVNUM_T_FMT into %s
>>>and calls to svn_revnum_to_cstring in *printf functions. Mostly it is
>>>error messages and other user messages that I've touched. I haven't
>>>modified things that aren't supposed to be localized later.
>>>
>>>
>>>
>>>
>>Let's all take a deep breath now. The more I look at these patches, the
>>more horrible they seem. svn_revnum_t is typedefed to "long int", and
>>SVN_REVNUM_T_FMT is %ld. If we don't intend to change that (and
>>obviously we don't, in the forseeable future) then all of these changes
>>are nonsense and needless complication. Let's just use %ld and be done
>>with it.
>>
>>
>>
>I agree that it is probably unnecessary indirection. I thought the
>consensus was to keep SVN_REVNUM_T_FMT (implying that some form of my patch is
>necessary), however.
>
>Please, consensus on this matter would be useful before I spend more time
>on this patch (and possibly start another boring walkthrough replacing
>SVN_REVNUM_T_FMT with something...
>
>

When we decided on keeping SVN_REVNUM_T_FMT, I don't think anybody
expected such a huge change in the code. I certainly didn't. Now that I
see the results, I'd just use %ld in messages.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 8 21:18:11 2004

This is an archived mail posted to the Subversion Dev mailing list.