Re: [PATCH] svn_load_dirs.pl patch for Win32

On Mon, May 03, 2004 at 04:49:49PM +0100, Ian Brockbank wrote:
> Hi,
>
> As I posted on the users list, I had to make a few modifications to get
> svn_load_dirs.pl working on Windows XP (with ActivePerl 5.8). Here's
> the patch:
>
> Log message:
>
> Get svn_load_dirs.pl working on Windows.
>
> * svn_load_dirs.pl.in
> (main code, setting up $temp_dir): Add lookup of $ENV{TEMP} if
> $ENV{TMPDIR} isn't found.
>
> (main code, processing properties): Windows chokes on multi-line
> commands, caused (potentially) by properties. Write to a temporary
> file and use --file instead of passing the value. This also
> requires
> use of File::Temp::tempfile().
>
> (safe_read_from_pipe): open(HANDLE, "-|"); doesn't work on Windows.
> Replaced it with open(HANDLE, "@commandline |"); on Windows.
> This also necessitates pre-processing the command line to protect
> it from the Windows shell, and passing comments via a temporary
> file using --file instead of -m.

See my comments on the last patch...

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org