[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FS abstraction and node-rev IDs

From: <kfogel_at_collab.net>
Date: 2004-05-03 15:35:37 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> * Deprecate svn_fs_unparse_id(), make an svn_fs_unparse_id2() which
> accepts an FS object, and make it so code using
> svn_fs_unparse_id() only works with BDB FS IDs.
>
> * Stick an FS-type identifier on node-rev IDs which don't belong to
> BDB filesystems, and use that identifier to look up the vtable
> name. This seems like a potential source of security problems if
> any code accepts node-rev IDs from an untrusted source; we'd have
> to be careful in every FS function which uses node-rev IDs to
> ensure that we weren't fooled into parsing the ID into the wrong
> kind of structure.

+1 on the first option. Our convention seems to be that the fs object
contains the type identifier. If we deviate from that, we could start
having to stick type bits lots of places. Better to have consistency
and an extra argument, and not end up reimplementing (say) the X
Windows protocol API :-).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 3 16:49:16 2004

This is an archived mail posted to the Subversion Dev mailing list.