[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9340 - trunk

From: Max Bowsher <maxb_at_ukf.net>
Date: 2004-04-14 00:25:23 CEST

Philip Martin wrote:
> "Max Bowsher" <maxb@ukf.net> writes:
>
>> Ben Reser wrote:
>>> On Mon, Apr 12, 2004 at 05:24:30PM -0500, maxb@tigris.org wrote:
>>>> Author: maxb
>>>> Date: Mon Apr 12 17:23:56 2004
>>>> New Revision: 9340
>>>>
>>>> Modified:
>>>> trunk/build.conf
>>>> Log:
>>>> * build.conf (libsvn_swig_py): Add "swig_runtime" to "libs".
>>>>
>>>>
>>>> Modified: trunk/build.conf
>>>>
>>
============================================================================
>> ==
>>>> --- trunk/build.conf (original)
>>>> +++ trunk/build.conf Mon Apr 12 17:23:56 2004
>>>> @@ -323,7 +323,7 @@
>>>> lang = python
>>>> path = subversion/bindings/swig/python/libsvn_swig_py
>>>> sources = swigutil_py.c
>>>> -libs = libsvn_subr libsvn_delta aprutil apriconv apr
>>>> +libs = swig_runtime libsvn_subr libsvn_delta aprutil apriconv apr
>>>> install = swig-py-lib
>>>> # need special build rule to include -DSWIGPYTHON
>>>> compile-cmd = $(COMPILE_SWIG_PY)
>>>
>>> Maybe I missed something but umm what is swig_runtime for?
>>
>> Because swigutil_py.c uses several SWIG_* functions, and so needs to link
>> against -lswigpy (at least on platforms which require all symbols to be
>> defined at link-time - e.g. MSWindows).
>
> Your change breaks my build (--with-swig=/usr/local/swig-1.3.21)
...
> That link is not using SWIG_LDFLAGS, the other links that use -lswigpy
> use LINK_PY_WRAPPER.

Apologies, I wasn't aware of that subtlety (my system uses swig in /usr, so
my testing didn't reveal the problem.).

I'm testing the following patch:

Index: build.conf
===================================================================
--- build.conf (revision 9344)
+++ build.conf (working copy)
@@ -324,6 +324,8 @@
 path = subversion/bindings/swig/python/libsvn_swig_py
 sources = swigutil_py.c
 libs = swig_runtime libsvn_subr libsvn_delta aprutil apriconv apr
+# need SWIG_LDFLAGS to be able to link swig_runtime
+link-cmd = $(LINK) $(SWIG_LDFLAGS)
 install = swig-py-lib
 # need special build rule to include -DSWIGPYTHON
 compile-cmd = $(COMPILE_SWIG_PY)

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 14 00:38:46 2004

This is an archived mail posted to the Subversion Dev mailing list.