[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: I18n patch

From: Erik Hülsmann <e.huelsmann_at_gmx.net>
Date: 2004-04-09 23:05:35 CEST
('binary' encoding is not supported, stored as-is) Hi Nicolas,

I'm working to get your patch committed, but I have a question.

In the section below, you could have added N_() around the const chars,
adding a gettext call where they are used. This would have left most of
the formatting in place. Did you have any specific reason to do it like
you did?

bye,

Erik.

>-/*** Code. ***/
>+#include "svn_private_config.h"
>
>-const char svn_cl__help_header[] =
>- "usage: svn <subcommand> [options] [args]\n"
>- "Type \"svn help <subcommand>\" for help on a specific subcommand.\n"
>- "\n"
>- "Most subcommands take file and/or directory arguments, recursing\n"
>- "on the directories. If no arguments are supplied to such a\n"
>- "command, it will recurse on the current directory (inclusive) by\n"
>- "default.\n"
>- "\n"
>- "Available subcommands:\n";
>-
>-const char svn_cl__help_footer[] =
>- "Subversion is a tool for version control.\n"
>- "For additional information, see http://subversion.tigris.org/\n"
>- "\n";
>
>+
>+/*** Code. ***/
>
> /* This implements the `svn_opt_subcommand_t' interface. */
> svn_error_t *
>@@ -73,15 +59,25 @@ svn_cl__help (apr_getopt_t *os,
> svn_stringbuf_appendstr (ra_desc_all, ra_desc_body);
>
> SVN_ERR (svn_opt_print_help (os,
>- "svn", /* ### erm, derive somehow? */
>- opt_state ? opt_state->version : FALSE,
>- opt_state ? opt_state->quiet : FALSE,
>- ra_desc_all->data,
>- svn_cl__help_header,
>- svn_cl__cmd_table,
>- svn_cl__options,
>- svn_cl__help_footer,
>- pool));
>+ "svn", /* ### erm, derive somehow? */
>+ opt_state ? opt_state->version : FALSE,
>+ opt_state ? opt_state->quiet : FALSE,
>+ ra_desc_all->data,
>+ _("usage: svn <subcommand> [options] [args]\n"
>+ "Type \"svn help <subcommand>\" for help on a specific subcommand.\n"
>+ "\n"
>+ "Most subcommands take file and/or directory arguments, recursing\n"
>+ "on the directories. If no arguments are supplied to such a\n"
>+ "command, it will recurse on the current directory (inclusive) by\n"
>+ "default.\n"
>+ "\n"
>+ "Available subcommands:\n"),
>+ svn_cl__cmd_table,
>+ svn_cl__options,
>+ _("Subversion is a tool for version control.\n"
>+ "For additional information, see http://subversion.tigris.org/\n"
>+ "\n"),
>+ pool));

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 9 23:06:26 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.