[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix commit_tests 17 on Cygwin

From: <kfogel_at_collab.net>
Date: 2004-03-30 17:20:06 CEST

"Max Bowsher" <maxb@ukf.net> writes:
> [[[
> Make commit_tests test 17 pass on Cygwin.
>
> * subversion/tests/clients/cmdline/commit_tests.py
> (commit_uri_unsafe): Cygwin inherits Windows filesystem limitations
> - no '<' or '>' allowed in filenames.
> '$' is not a suitable substitute, as it expands as a shell variable.
> ]]]

Good catch. Looks good to me (and I assume, from the conditionals,
that this still passes under regular Unix and regular Windows?).

(+1 to commit)

-Karl

> Index: subversion/tests/clients/cmdline/commit_tests.py
> ===================================================================
> --- subversion/tests/clients/cmdline/commit_tests.py (revision 9232)
> +++ subversion/tests/clients/cmdline/commit_tests.py (working copy)
> @@ -1066,9 +1066,9 @@
>
> # Note: on Windows, files can't have angle brackets in them, so we
> # don't tests that case.
> - if svntest.main.windows:
> - angle_name = '$angle$'
> - nasty_name = '#![]{}()$$%'
> + if svntest.main.windows or sys.platform == 'cygwin':
> + angle_name = '_angle_'
> + nasty_name = '#![]{}()__%'
> tab_name = 'tab-path'
> else:
> angle_name = '<angle>'
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 30 18:31:22 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.