Re: Missing error messages with svn_error_quick_wrap [was: Re: " Inconsistent line-endings"]

On Sun, 2004-03-21 at 18:44, Julian Foad wrote:
> It is recognizable programmatically: the error code "SVN_ERR_BASE"
> means "This is a wrapper; see the inner error for details including
> the specific error code." Is there a problem with that?

Yes. Compare:

  if (err->apr_err == SVN_ERR_BLAH)

to:

  for (rerr = err; rerr->apr_err == SVN_ERR_BASE; rerr = rerr->child)
    ;
  if (rerr->apr_err == SVN_ERR_BLAH)

> > I think the svn_handle_error behavior for this case is probably historic
> > and unjustified; it would be better to change the handling behavior than
> > the wrapping behavior.
>
> I thought about ways to change that and could not find a satisfactory way. Can you?

Maybe just punt the print_strerror parameter to print_error, and always
print a message (either the APR one or the more specific one if
provided). It's hard to imagine why there would ever be an exact
duplicate of an error in the call chain.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 22 03:35:59 2004