Re: [PATCH] [Issue 1751] file not switched if it is the same in source and destination

Philip Martin wrote:

> makl <makl@tigris.org> writes:

> I feel there is too much code duplication, would it be possible to use
> a single tweak_entries function with a recurse flag?

No problem.

>>+ /* Read DIRPATH's entries. */
>>+ SVN_ERR (svn_wc_entries_read (&entries, dirpath, TRUE, subpool));
>
> I know you copied this code, but the pool handling isn't correct.
> It should be using pool here, not subpool.

Potentially we read a big bunch of entries and i think the memory should
be freed as soon as possible. And for the recursive case, after
completing the operation we have all entries of the complete working
copy in memory. This sounds not correct for me.

>> # Check out the trunk as "wc2"
>>- svntest.main.run_svn(None, 'co', '-N', trunk_url, wc2_dir)
>>+ svntest.main.run_svn(None, 'co', trunk_url, wc2_dir)
>
>
> That's quite a change, is this test still testing whatever it was
> supposed to test originally?

Remember the recipe. For this two cases it's irrelevant whether the WC
is checked out recursively or not.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 21 21:23:19 2004